Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Firefox] Flickering happens on a special case - cosmetic filters #535

Closed
g3939434 opened this issue Jul 26, 2015 · 3 comments
Closed

[Firefox] Flickering happens on a special case - cosmetic filters #535

g3939434 opened this issue Jul 26, 2015 · 3 comments
Labels
unable to reproduce

Comments

@g3939434
Copy link

Firefox 39.0, uBlock Origin 1.0.0.0

Flickering happens on a special case when using cosmetic filters, no matter if they are specific cosmetic filters or cached generic cosmetic filters which should injected before page's root DOM is loaded.

Steps to Reproduce:

  1. Create filter bbs.pcbeta.com##.hdc > h2

  2. Go to http://bbs.pcbeta.com/ and the logo on the top left corner should be hidden but with flickering.

  3. Reload the page and flickering still happens.

This behavior does not happen in chrome. I don't know if this is an expected behavior due to different rendering engine, or the result of fix on chrisaljoudi/uBlock issue 789.

Additional Information:

  1. The page use a script to remove style tag. So blocking 3p-script will not happen flickering.
  2. Enable Shadow DOM dom.webcomponents.enabled, flickering still happens.
  3. uBlock Origin chrome version does not happen flickering.
  4. Adblock Plus does not happen flickering.
  5. Stylish does not happen flickering.
@wlq105556
Copy link

The same to me. This animation:
http://i62.tinypic.com/34smour.gif
Everytime I reloaded pages of this site, the ad banner flicked and disappeared immediately.

@gorhill
Copy link
Owner

gorhill commented Jul 27, 2015

As mentioned by OP, the page remove the style tags, so uBlock has to re-insert it. Shadow DOM does not help currently here because when the specific style was injected, the node to hide did not exist yet, so it could not be "shadowed". However I could try to shadow it when I re-insert the style tag.

That this does not happen in Chromium is probably just because of different rendering engines between FF/Chromium.

@gorhill
Copy link
Owner

gorhill commented Sep 11, 2017

Not an issue anymore since uBO uses user stylesheets on Firefox.

@gorhill gorhill closed this as completed Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unable to reproduce
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gorhill @g3939434 @wlq105556